D29119: Dolphin: Implement package kit for deb/rpm service packages

[Méven Car]

meven requested changes to this revision.
meven added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> servicemenuinstaller.cpp:67
> +                        }
> +                        fail(i18n("Package installation exited with status \"%1\"",
> +                                QVariant::fromValue(status).toString()));

Mention the fileName in the error message.

> servicemenuinstaller.cpp:83
> +                                              }
> +                                              fail(i18n("Package removal exited with status \"%1\"",
> +                                                            QVariant::fromValue(status).toString()));

Mention the fileName in the error message.

> servicemenuinstaller.cpp:91
> +                         if (status != PackageKit::Transaction::ExitSuccess) {
> +                             fail(i18n("Package removal failed exited with status \"%1\"",
> +                                       QVariant::fromValue(status).toString()));

Mention the fileName in the error message.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29119

To: alex, #dolphin, ngraham, elvisangelaccio, meven
Cc: meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200424/d95a7970/attachment.htm>