D28402: Provide ability to configure size cut-off for local file previews

[Gaston Haro]

harogaston added a comment.


  In D28402#655312 <https://phabricator.kde.org/D28402#655312>, @meven wrote:
  
  > Should we make the information panel follow those settings as well (currently the preview there has no limit, nor plugin limitations) ?
  >  Same question about tooltips.
  >
  > I think we should. Essentially copying to there code :
  >
  >   const KConfigGroup globalConfig(KSharedConfig::openConfig(), "PreviewSettings");
  >    m_enabledPlugins = globalConfig.readEntry("Plugins", KIO::PreviewJob::defaultPlugins());
  >    m_localFileSizeLimit = globalConfig.readEntry("LimitLocalFiles", false);
  
  
  I think I agree with you even though I didn't get your point regarding the code snippet.
  In any case I guess that idea should be part of a new patch, do you agree?

REPOSITORY
  R318 Dolphin

BRANCH
  gui-setting-to-limit-local-file-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28402

To: harogaston, ngraham, #dolphin, meven, elvisangelaccio
Cc: cfeck, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200423/cc2f2d06/attachment.htm>