D29001: Information Panel : adapt preview for HiDPI
Méven Car
noreply at phabricator.kde.org
Thu Apr 23 07:48:02 BST 2020
meven added a comment.
In D29001#654410 <https://phabricator.kde.org/D29001#654410>, @broulik wrote:
> > Do you recommend me to abandon this then ?
>
> I think in this particular instance is fine, but could lead to small text for text preview?
>
> > it won't break anything or at least we can implement it in a retro-compatible way.
>
> If you have an idea how, sure. You can't add new virtuals to `ThumbCreator` class, though. Not too keen on having a `V2`, though.
I was thinking modifying the `virtual bool create(const QString &path, int width, int height, QImage &img)` adding it a devicePixelRatio qreal parameter.
I am not sure it will break this way.
So that may we need a KF6 task indeed.
REPOSITORY
R318 Dolphin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29001
To: meven, #dolphin, ngraham, elvisangelaccio
Cc: broulik, elvisangelaccio, bugseforuns, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200423/c87d2b2b/attachment.htm>
More information about the kfm-devel
mailing list