D29118: Network Filesharing: Refactor foreach and emit, smaller improvements

Alexander Lohnau noreply at phabricator.kde.org
Thu Apr 23 05:45:24 BST 2020


alex created this revision.
alex added reviewers: Dolphin, ngraham.
alex requested review of this revision.

REVISION SUMMARY
  Compile without emit and foreach.
  The private variables inside the model are prefixed with _, because
  the userList variable shadowed class definition. This should clear things up.
  
  And some better overloads and const qualifiers.

TEST PLAN
  Compiles

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29118

AFFECTED FILES
  CMakeLists.txt
  samba/filepropertiesplugin/model.cpp
  samba/filepropertiesplugin/model.h
  samba/filepropertiesplugin/sambausershareplugin.cpp

To: alex, #dolphin, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200423/4a51bf30/attachment.htm>


More information about the kfm-devel mailing list