D29115: Add option to show hidden files and folders last

Gaston Haro noreply at phabricator.kde.org
Thu Apr 23 04:50:48 BST 2020


harogaston created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
harogaston requested review of this revision.

REVISION SUMMARY
  Adds a new checkbox to choose to list hidden files and folders after those not hidden. Other sorting criteria (size, date, etc) is applied afterwards.

TEST PLAN
  1. Open a directory with a mixture of hidden and not hidden files and folders.
  2. Select a sorting i.e. default, size, creation date, last modification date.
  3. Go to menu View -> Sort By -> Hidden Last and check the new option (by default it is unchecked). Alternatively do the same from the folder view context menu.
  4. Not hidden files should appear before hidden (or dot) files. Files and folders from each of these categories shuold still follow the sorting selection made previously.
  5. If Dolphin is configured to 'Remember properties for each folder' a new entry will appear in the '.directory' file called HiddenLast
  
  PS: I would like to write a new test in `kfileitemmodeltest.cpp` but I don't know how to run the tests. Any help would be appreciated.

REPOSITORY
  R318 Dolphin

BRANCH
  dot-files-last

REVISION DETAIL
  https://phabricator.kde.org/D29115

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp
  src/kitemviews/kfileitemmodel.h
  src/settings/dolphin_directoryviewpropertysettings.kcfg
  src/settings/viewpropertiesdialog.cpp
  src/settings/viewpropertiesdialog.h
  src/views/dolphinview.cpp
  src/views/dolphinview.h
  src/views/dolphinviewactionhandler.cpp
  src/views/dolphinviewactionhandler.h
  src/views/viewproperties.cpp
  src/views/viewproperties.h

To: harogaston
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200423/cf796dd1/attachment.htm>


More information about the kfm-devel mailing list