D29001: Information Panel : adapt preview for HiDPI

[Méven Car]

meven added a comment.


  In D29001#653284 <https://phabricator.kde.org/D29001#653284>, @broulik wrote:
  
  > > It does not, this one is about the main files view.
  > >  But the fix will be quite similar.
  >
  > This approach is wrong though, for the main files view in particular. There's a difference between loading e.g. a 32px icon, and a 16px @2x scaling.
  >  Doesn't really matter for the preview pane's large icon size but for the icon view it could have undesired side effects of using a non-symbolic icon when it should by symbolic, or having an icon with too small detail
  
  
  Do you recommend me to abandon this then ?
  
  In D29001#653282 <https://phabricator.kde.org/D29001#653282>, @broulik wrote:
  
  > Do we have a KF6 task for this to add support for dpr to this? Adding it to the `PreviewJob` should be straightforward, but we cannot really change the preview plug-ins class.
  
  
  I have tried to implement to add a setDevicePixelRatio to PreviewJob and in turn add it to the thumbnail ioslave and ThumbCreator.
  I don't think we have to wait for KF6 for it, it won't break anything or at least we can implement it in a retro-compatible way.
  But this requires some work.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29001

To: meven, #dolphin, ngraham, elvisangelaccio
Cc: broulik, elvisangelaccio, bugseforuns, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200422/a5a5cc95/attachment.htm>