D29006: Add feature to copy or move selection to the opposite panel

[Méven Car]

meven added a comment.


  > It does work, BUT dolphin stops responding for 1-2 minutes. Need help with this.
  
  Are you testing on network filesystem ?
  Avoid it, if it is so, this is a known issue https://phabricator.kde.org/T11627
  
  Otherwise `sudo gdb -pid $(pidof dolphin) `
  In gdb > `thread apply all bt`
  It should help you point where dolphin is busy.
  
  Looks fine otherwise, just a few text/naming to improve.
  Ctrl+Z should even work I believe.
  
  Use view naming instead of panel : panels are on the window sides, here we talk about split views.
  
  Not too sure about the shortcuts you chose. Are they inspired by something ?
  
  Maybe disable those actions when the split views are disabled, it should grey out the button should a user add them to their toolbar.

INLINE COMMENTS

> dolphinmainwindow.cpp:1408
>  
> +    QAction* copyToOppositePanelAction = actionCollection()->addAction(QStringLiteral("copy_to_opposite_panel"));
> +    copyToOppositePanelAction->setText(i18nc("@action:inmenu", "Copy to opposite panel"));

copy_to_other_split_view

> dolphinmainwindow.cpp:1409
> +    QAction* copyToOppositePanelAction = actionCollection()->addAction(QStringLiteral("copy_to_opposite_panel"));
> +    copyToOppositePanelAction->setText(i18nc("@action:inmenu", "Copy to opposite panel"));
> +    copyToOppositePanelAction->setWhatsThis(xi18nc("@info:whatsthis Copy", "This copies the items from "

Copy selection to the other view

> dolphinmainwindow.cpp:1410
> +    copyToOppositePanelAction->setText(i18nc("@action:inmenu", "Copy to opposite panel"));
> +    copyToOppositePanelAction->setWhatsThis(xi18nc("@info:whatsthis Copy", "This copies the items from "
> +        "the <emphasis>active</emphasis> panel to the inactive panel."));

This copies the items from " -> This copies the selected items from "

> dolphinmainwindow.cpp:1411
> +    copyToOppositePanelAction->setWhatsThis(xi18nc("@info:whatsthis Copy", "This copies the items from "
> +        "the <emphasis>active</emphasis> panel to the inactive panel."));
> +    copyToOppositePanelAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-copy")));

s/panel to the inactive panel/view to the other split view

> dolphinmainwindow.cpp:1416
> +
> +    QAction* moveToOppositePanelAction = actionCollection()->addAction(QStringLiteral("move_to_opposite_panel"));
> +    moveToOppositePanelAction->setText(i18nc("@action:inmenu", "Move to opposite panel"));

move_to_other_split_view

> dolphinmainwindow.cpp:1417
> +    QAction* moveToOppositePanelAction = actionCollection()->addAction(QStringLiteral("move_to_opposite_panel"));
> +    moveToOppositePanelAction->setText(i18nc("@action:inmenu", "Move to opposite panel"));
> +    moveToOppositePanelAction->setWhatsThis(xi18nc("@info:whatsthis Move", "This moves the items from "

Move selection to the other view

> dolphinmainwindow.cpp:1419
> +    moveToOppositePanelAction->setWhatsThis(xi18nc("@info:whatsthis Move", "This moves the items from "
> +        "the <emphasis>active</emphasis> panel to the inactive panel."));
> +    moveToOppositePanelAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-cut")));

s/panel to the inactive panel/view to the other split view

> dolphinmainwindow.h:258
> +    /** Copies all selected items to the opposite panel. */
> +    void copyToOppositePanel();
> +

s/copyToOppositePanel/copyToOtherView

> dolphinmainwindow.h:261
> +    /** Moves all selected items to the opposite panel. */
> +    void moveToOppositePanel();
> +

s/moveToOppositePanel/moveToOtherView

> dolphinview.cpp:695
>  
> +void DolphinView::copySelectedItemsToOppositePanel(QUrl destinationPanelUrl)
> +{

copySelectedItemsToOtherSplitView

> dolphinview.cpp:701
> +
> +void DolphinView::moveSelectedItemsToOppositePanel(QUrl destinationPanelUrl)
> +{

moveSelectedItemsToOtherSplitView

> dolphinview.h:368
> +    /**
> +     * Copies all selected items to the opposite panel.
> +     * Only available in Split View.

s/opposite panel/other view

> dolphinview.h:374
> +    /**
> +     * Moves all selected items to the opposite panel.
> +     * Only available in Split View.

s/opposite panel/other view

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela
Cc: meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200421/312d954e/attachment.htm>