D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything.

[Nikolai Krasheninnikov]

nikolaik added a comment.


  In D29043#653471 <https://phabricator.kde.org/D29043#653471>, @meven wrote:
  
  > In D29043#653435 <https://phabricator.kde.org/D29043#653435>, @nikolaik wrote:
  >
  > > In D29043#653429 <https://phabricator.kde.org/D29043#653429>, @meven wrote:
  > >
  > > > I would have updated `static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0);` to match its documentation instead
  > >
  > >
  > > Can you please explain what do you mean? The documentation is also fixed and i think is correct now.
  >
  >
  > Returning an empty QVector instead of null in `getLog` would have sufficed and would be somewhat safer as the documentation suggested it did, but didn't.
  >  Anyway that's not very important.
  
  
  True, but there is one case where empty history is not an error: just created repository.
  Returning a nullptr covers this case.

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29043

To: nikolaik, #dolphin, meven, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200421/134c18eb/attachment.htm>