D26215: Port QRegExp to QRegularExpression

[Elvis Angelaccio]

elvisangelaccio added a comment.


  > KFileItemModelFilter still uses QRegExp as there's no equivalent in QRegularExpression
  >  to QRegExp::WildcardUnix.
  
  Is there any plan to fix this upstream in Qt?

INLINE COMMENTS

> dolphinpart.cpp:511-512
>      if (okClicked && !pattern.isEmpty()) {
> -        QRegExp patternRegExp(pattern, Qt::CaseSensitive, QRegExp::Wildcard);
> +        const QRegularExpression patternRegExp(
> +                                        QRegularExpression::wildcardToRegularExpression(pattern));
>          m_view->selectItems(patternRegExp, selectItems);

Please  use a single line.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26215

To: ahmadsamir, #dolphin, elvisangelaccio, meven
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200420/3dd67402/attachment.htm>