D28909: smb: port to Result system to force serialization of error/finish condition

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> dfaure wrote in kio_smb.h:96
> Whenever we port a 3rd slave to it ;-)

Sure, if you think it's solid enough from an API POV.

I was thinking that we should amend the slavebase API for KF6 in general. Instead of having error/finished/opened all functions on an API level should return a Result and the slave loop would emit the relevant signal based on the Result. IOW: what currently happens in the derived SlaveBases actually ought to be KIO-internal.

That would then also allow us to get rid of the two-class split again. And the "fronting" class is actually a much bigger concern than Result to me. The call finalization logic is 100% code copy and so very easy to get wrong (e.g. sftp's special() not finishing when in fact it should).

> dfaure wrote in kio_smb.h:269
> parse error?

That line only moved, I am not quite sure what it is meant to tell us though. The header is and was quite the mess.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28909

To: sitter, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200420/d82c276d/attachment.htm>