D26215: Port QRegExp to QRegularExpression

Méven Car noreply at phabricator.kde.org
Mon Apr 20 08:26:54 BST 2020


meven added inline comments.

INLINE COMMENTS

> dolphinpart.cpp:510
>      if (okClicked && !pattern.isEmpty()) {
> -        QRegExp patternRegExp(pattern, Qt::CaseSensitive, QRegExp::Wildcard);
> +        QRegularExpression patternRegExp(QRegularExpression::wildcardToRegularExpression(pattern));
>          m_view->selectItems(patternRegExp, selectItems);

const

> dolphinview.cpp:376
>          const KFileItem item = m_model->fileItem(index);
> -        if (pattern.exactMatch(item.text())) {
> +        QRegularExpressionMatch match = regexp.match(item.text());
> +        if (match.hasMatch()) {

const

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26215

To: ahmadsamir, #dolphin, elvisangelaccio, meven
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200420/4bf46fe6/attachment.htm>


More information about the kfm-devel mailing list