D28402: Provide ability to configure size cut-off for local file previews

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I see that previews being disabled when these settings are changes also requires a refresh for remote files, so this isn't a new problem you've introduced or a deficiency with your patch; rather, it's a missing feature in kfileitemmodelrolesupdater. Fixing that for both local and remove previews might be a good follow-up patch. ;-)
  
  Just one little nitpick left to resolve from me:

INLINE COMMENTS

> previewssettingspage.h:23
>  
> +#include <QtWidgets/QCheckBox>
>  #include "settings/settingspagebase.h"

Just forward-declare this, as with the below `class [thing]` lines. Also, no need to include the `QtWidgets/` prefix.

REPOSITORY
  R318 Dolphin

BRANCH
  gui-setting-to-limit-local-file-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28402

To: harogaston, ngraham, #dolphin, meven, elvisangelaccio
Cc: cfeck, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200419/93633244/attachment.htm>