D28402: Provide ability to configure size cut-off for local file previews

[Nathaniel Graham]

ngraham added a comment.


  Thanks, much better.
  
  I see what you mean about the setting only taking effect after a restart though. I'll have to defer to @meven or @elvisangelaccio on that.

INLINE COMMENTS

> previewssettingspage.cpp:79
> +    m_localFileSizeBox->setSuffix(QStringLiteral(" MB"));
> +    m_localFileSizeBox->setRange(0, 9999999); /* MB */
> +

A minimum of zero doesn't really make sense; if a person wants to turn off all previews, there's already a button for that in the main toolbar. IMO a minimum of 1 (or even higher) would make more sense here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28402

To: harogaston, ngraham, #dolphin, meven, elvisangelaccio
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200417/bf365547/attachment.htm>