D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> thumbnail.cpp:729
> +            const auto thumbRootMount = mountsList.findByPath(m_thumbBasePath);
> +            //If file is on the same filesystem as thumbnail directory, we can cache it.
> +            const bool isEncrypted = mount != thumbRootMount && (mount->mountType() == QLatin1String("fuse.cryfs") || mount->mountType() == QLatin1String("fuse.encfs"));

This can be checked much faster by comparing the device ids from a stat call. Then the code would also better match the comment.

Though, being on the same FS is a sufficient condition to create the thumbnail, it is not required. So the condition should probably read:

  dev_t fileDevId = ...
  if (m_thumbnailDirDeviceId != fileDevId) {
     bool isEncrypted = ...
     if (isEncrypted) {
      continue; // or return or whatever ...
     }
  }

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200416/5ea6067c/attachment.htm>