D26362: Move from the searchbox to the results with the down arrow key

Nathaniel Graham noreply at phabricator.kde.org
Wed Apr 15 14:39:23 BST 2020


ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Actually I see a change that's needed: when the return key is pressed, it triggers `DolphinSearchBox::returnPressed()`, but when the down arrow key is pressed, it triggers `DolphinSearchBox::focusViewRequest()` And I notice that `returnPressed()` emits the search result too. So now with this patch we have two inconsistent codepaths to get to the same thing. We should probably unify these so that both trigger your new `focusViewRequest()` signal, and make sure that it emits the search result too.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26362

To: shlomif, ngraham, #dolphin
Cc: meven, elvisangelaccio, ngraham, iasensio, kfm-devel, azyx, nikolaik, pberestov, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200415/3e514191/attachment.htm>


More information about the kfm-devel mailing list