D28795: Dolphin Services: Launch Deb/Rpm archives with QDesktopServices

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> servicemenuinstaller.cpp:39
>  
> +    // TODO Use KNotifications?
>      QProcess process;

unrelated to this patch; don't change it here regardless

> servicemenuinstaller.cpp:90
>      UncompressCommand command{};
> +    // TODO qAsConst ?
>      for (const auto &pair : mimeTypeToCommand) {

unrelated to this patch; don't change it here regardless

> servicemenuinstaller.cpp:279
>          QString deinstallPath;
> +        // TODO Support names like uninstall? Maybe more intuitive
>          const auto basenames1 = QStringList{"deinstall.sh", "deinstall"};

unrelated to this patch; don't change it here regardless

> servicemenuinstaller.cpp:331
>  {
> -    QCoreApplication app(argc, argv);
> +    QGuiApplication app(argc, argv);
>  

Why change this?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28795

To: alex, #dolphin, elvisangelaccio, ngraham, aspotashev
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200413/9467ee19/attachment.htm>