[dolphin] [Bug 419585] Dolphin crashes most of the time on start when QT is updated to 5.14.2

Martin Sandsmark bugzilla_noreply at kde.org
Sun Apr 12 11:17:54 BST 2020


https://bugs.kde.org/show_bug.cgi?id=419585

Martin Sandsmark <martin.sandsmark at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/35b4c6d4df1281afd62137
                   |                            |4e686f19e654ad7bae

--- Comment #14 from Martin Sandsmark <martin.sandsmark at kde.org> ---
Git commit 35b4c6d4df1281afd621374e686f19e654ad7bae by Martin T. H. Sandsmark.
Committed on 12/04/2020 at 10:15.
Pushed by sandsmark into branch 'release/20.04'.

Fix crashing on starting and quitting

QCollator (especially with Qt 5.14 and ICU 65.1) is very unhappy with
threads.

To avoid having to lock and unlock the mutex everywhere (and ensure it
is unlocked before calling other things that might lock it, etc.), we do
it as locally as possible. Even if for some reason Qt and ICU make
QCollator threadsafe in the future locking here should have minimal
impact.

Differential Revision: https://phabricator.kde.org/D28659

M  +5    -0    src/kitemviews/kfileitemmodel.cpp

https://commits.kde.org/dolphin/35b4c6d4df1281afd621374e686f19e654ad7bae

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the kfm-devel mailing list