D28681: [svn] Fixed items status inside unversioned directory.

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Looks good otherwise.

INLINE COMMENTS

> fileviewsvnplugin.cpp:676
> +
> +    auto it = m_versionInfoHash.cbegin();
> +    for ( ; it != m_versionInfoHash.cend(); ++it) {

Please move this declaration inside the `for`

> fileviewsvnplugin.cpp:679
> +        // Add QDir::separator() to m_versionInfoHash entry to ensure this is a directory.
> +        if ( it.value() == UnversionedVersion && itemPath.startsWith(it.key() + QDir::separator()) ) {
> +            return true;

Code style: remove space after ( and before )

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28681

To: nikolaik, meven, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200412/9f794195/attachment.htm>