D11382: Add an option to show tabs from last time when Dolphin starts

Nathaniel Graham noreply at phabricator.kde.org
Thu Apr 9 18:13:15 BST 2020


ngraham added inline comments.

INLINE COMMENTS

> feverfew wrote in main.cpp:143
> I don't understand the point of this variable, just use `urls.isEmpty()` when needed

It's because we later mutate `urls`, so we need to know if it was empty originally, not that it's currently empty. I'll add a comment for clarity.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11382

To: ngraham, #dolphin, #vdg, feverfew, meven, elvisangelaccio, ndavis
Cc: davidedmundson, ndavis, intika, feverfew, kfm-devel, ngraham, broulik, #dolphin, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200409/622efa57/attachment.htm>


More information about the kfm-devel mailing list