D28659: Fix crashing on starting and quitting
Martin Tobias Holmedahl Sandsmark
noreply at phabricator.kde.org
Tue Apr 7 16:18:10 BST 2020
sandsmark created this revision.
sandsmark added reviewers: Dolphin, elvisangelaccio.
sandsmark added a project: Dolphin.
Herald added a subscriber: kfm-devel.
sandsmark requested review of this revision.
REVISION SUMMARY
To avoid having to lock and unlock the mutex everywhere (and ensure it is unlocked before calling other things that might lock it, etc.), do it as locally as possible.
TEST PLAN
Doesn't crash all the time anymore, and doesn't randomly hang like when I tried to lock and unlock it "manually" everywhere.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D28659
AFFECTED FILES
src/kitemviews/kfileitemmodel.cpp
To: sandsmark, #dolphin, elvisangelaccio
Cc: kfm-devel, #dolphin, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200407/4f95014a/attachment.htm>
More information about the kfm-devel
mailing list