D28290: Sync terminal with KIOFuse mount when browing remote directories

Fabian Vogt noreply at phabricator.kde.org
Mon Apr 6 07:17:30 BST 2020


fvogt accepted this revision.
fvogt added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> elvisangelaccio wrote in terminalpanel.cpp:288
> Prefer `QLatin1String` for comparisons.

Only for comparisons with `const char*` AFAICT. Here it would probably cause a malloc on each comparison instead.

REPOSITORY
  R318 Dolphin

BRANCH
  syncTerminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28290

To: feverfew, #dolphin, fvogt, elvisangelaccio
Cc: elvisangelaccio, fvogt, kfm-devel, ngraham, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200406/e02012f4/attachment.htm>


More information about the kfm-devel mailing list