D28227: Use same logic for "no extension" case with Duplicate feature

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> dolphinview.cpp:740
>              const QString originalExtension = originalFileName.right(extension.size());
> -            duplicateURL.setPath(i18nc("<file path><filename> copy.<extension>", "%1%2 copy%3", directoryPath, originalFilenameWithoutExtension, originalExtension));
> +            duplicateURL.setPath(originalDirectoryPath + i18nc("<filename> copy.<extension>", "%1 copy", originalFilenameWithoutExtension) + originalExtension));
>          }

i tihnk i would remove the .<extension> part, it's not part of the translatable string so it can be a bit confusing, also it's not like it gives translators anything they can work with, no?

I mean why would it translate differently whether the filename has an extension or not?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28227

To: ngraham, #dolphin, elvisangelaccio, arojas, meven, pino, #localization
Cc: aacid, kfm-devel, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200404/8a5992af/attachment.htm>