D28513: smb: use prettyname.local for hostname of wsdiscoveries

[Harald Sitter]

sitter added a comment.


  Stable was the plan, yes.
  
  I've thought of some complications with this approach though. Actually a combination of two
  
  1. the .local match also applies to dnssd
  2. all linux VMs I've checked wouldn't be able to resolve netbios names natively as the relevant modules are simply not loaded by default. meaning the netbios fallback will never be hit because 'foo' cannot ever be resolved (well, unless the user manually enables nmbd or lllmnr resolution)
  
  to mitigate 2 we could just always fall back to netbios regardless of its resolvability, but that has the problem that we can then discover DNSSD services on bar.local have that fall back to bar and somewhat unexpected report that 'bar' was not resolvable (when in fact the intended and wanted resolution is bar.local for the DNSSD scenario). I'm not sure it's a huge problem, but it certainly irks me a bit because very practically libsmbc's resolution may be way more flexible than the regular libc/nss resolution.
  
  OTOH fixing both would require yet more URL hackery to carry more context from the discovery into the list call. by either making the hostname `foo.kio-discovery-wsd` instead of `foo.local` or putting the discovery method into a query `smb://foo?kio-discovery=wsd`. I find both a bit meh. but then dnssd can be entirely unaffected by any of this

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200403/1efd4da6/attachment.htm>