D20532: Proof of Concept: Add double click actions to empty space in the folder view

Méven Car noreply at phabricator.kde.org
Wed Apr 1 13:53:10 BST 2020


meven added a comment.


  > ! In D20532#601023 <https://phabricator.kde.org/D20532#601023>, @ngraham wrote:
  >  https://bugs.kde.org/show_bug.cgi?id=307505 has two duplicates. We might want to reconsider.
  
  I agree with Nate, I think we should reconsider, based on user feedback.
  This is a power-user feature that should please this part of our user base.
  
  One use case appealed a lot to me in https://www.reddit.com/r/kde/comments/de4sun/dolphin_are_you_interested_in_a_double_click_on/ : the touchpad and touchscreen use case.
  Touchpad mouse are slow to move and are less precise, this would make sense for those use case.
  
  Plus the code is not that scary (just a few corrections left)
  
  So @elvisangelaccio Has your opinion changed ?

INLINE COMMENTS

> dhaumann wrote in kitemlistcontroller.cpp:821
> You should use static_cast only if you know 100% sure the type. But in this case the line below even checks against nullptr. So it seems you are not sure what you get. That's why using qobject_cast is the better/correct approach here.

Move to line 835.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20532

To: fbg13, #dolphin, elvisangelaccio, #vdg, ngraham
Cc: meven, maxts, dhaumann, rizzitello, anthonyfieroni, kneckermcknacksack, ngraham, kfm-devel, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200401/ef90947f/attachment.htm>


More information about the kfm-devel mailing list