Review Request 104915: Patch for dolphin that disables trash on removable media drives

[Alexander Skakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104915/
-----------------------------------------------------------

(Updated Sept. 29, 2019, 7:36 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Patch for dolphin that disables trash on removable media drives. When user opens context menu on file located on the removable media, "Move to trash" item is replaced with "Delete" item as well as "Del" keyboard shortcut executes "Delete" action instead of "Move to trash". Same behavior is already used for remote file systems, this patch just extends it for local but removable storages.
I can modify it to be optional if there is a need for this


Diffs
-----

  dolphin/src/CMakeLists.txt c00d29c 
  dolphin/src/dolphincontextmenu.cpp 286d304 
  dolphin/src/views/dolphinview.h b2c4121 
  dolphin/src/views/dolphinview.cpp 6a21885 
  dolphin/src/views/dolphinviewactionhandler.cpp 7f23b7d 


Diff: https://git.reviewboard.kde.org/r/104915/diff/1/


Testing
-------

On various USB flash disks, card readers, external USB HDD drives


Thanks,

Alexander Skakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190929/3d6efc9f/attachment.htm>