Review Request 115678: Make DolphinContextMenu independent

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115678/
-----------------------------------------------------------

(Updated Sept. 29, 2019, 7:13 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

* Removed all DolphinMainWindow and DolphinView dependencies in DolphinContextMenu.
* Removed some code duplications in DolphinContextMenu.
* Code cleanup in DolphinContextMenu.

We can now use DolphinContextMenu in other places too.

I hope this patch is not too huge for reviewing, but there was no good way to split it up.


Diffs
-----

  dolphin/src/dolphincontextmenu.h 180f917 
  dolphin/src/dolphincontextmenu.cpp f295de7 
  dolphin/src/dolphinmainwindow.h cb97612 
  dolphin/src/dolphinmainwindow.cpp 8473014 
  dolphin/src/views/dolphinview.h 3731464 
  dolphin/src/views/dolphinview.cpp 9f5f48a 


Diff: https://git.reviewboard.kde.org/r/115678/diff/1/


Testing
-------

Compiles. Works fine so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190929/3ed09f2d/attachment.htm>