Review Request 129525: possible one line bug in KItemListHeaderWidget::setColumns()

[Don Nguyen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129525/
-----------------------------------------------------------

(Updated Sept. 29, 2019, 5:07 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: dolphin


Description
-------

The current logic checks to see if a key is *NOT* in a hash, and removes it if it isn't.  I don't know exactly what's going on, but it doesn't make sense to me to remove something when it's not there so I suspect this is a bug.  I changed the logic to check if the hash does contain the key.


Diffs
-----

  src/kitemviews/private/kitemlistheaderwidget.cpp cc11e19 


Diff: https://git.reviewboard.kde.org/r/129525/diff/1/


Testing
-------

Don't know what to test, but make test passes.


Thanks,

Don Nguyen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190929/22514134/attachment.htm>