D24247: Expose full set of script execution options in settings window

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: elvisangelaccio, Dolphin, VDG.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the script execution setting is a checkbox, capable only of handling boolean
  input. This is not appropriate because there are actually three options available.
  
  Accordingly, this patch replaces the checkbox with a combobox (to save space compared
  to radio buttons) that clearly exposes all three options.

TEST PLAN
  F7440559: confirmation.png <https://phabricator.kde.org/F7440559>
  
  - All three options do what they say they'll do
  - All options get saved properly
  - The combobox displays the correct option when the window is loaded
  - The Defaults button resets it to "always ask" as expected

REPOSITORY
  R318 Dolphin

BRANCH
  multi-state-script-execution-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24247

AFFECTED FILES
  src/settings/general/confirmationssettingspage.cpp
  src/settings/general/confirmationssettingspage.h

To: ngraham, elvisangelaccio, #dolphin, #vdg
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190926/dfd02bc4/attachment.htm>