Review Request 107016: Make Find a toggle action

Àlex Fiestas afiestas at kde.org
Tue Sep 24 21:51:53 BST 2019


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107016/
-----------------------------------------------------------

(Updated Sept. 24, 2019, 8:51 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin, KDE Usability and Frank Osterfeld.


Repository: kde-baseapps


Description
-------

I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview.

The patch is pretty straight forward.


Diffs
-----

  dolphin/src/dolphinmainwindow.h 7da5801 
  dolphin/src/dolphinmainwindow.cpp b4a25a7 


Diff: https://git.reviewboard.kde.org/r/107016/diff/1/


Testing
-------


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190924/ff246908/attachment.htm>


More information about the kfm-devel mailing list