D24195: WebEnginePart: A new tab requested by user is not a popup

[Jonathan Marten]

marten created this revision.
marten added reviewers: Plasma, Konqueror.
marten requested review of this revision.

REVISION SUMMARY
  When using this viewer part, a new tab (requested by Ctrl-LMB or MMB over a link, when the "Open links in new tab..." option is on) seems to be treated as a popup window and puts up a message box "This site is requesting to open a popup window to...".  This is reasonable when a site is actually opening a popup, but for a user requested new tab it should not do this.  The popup menu "Open in New Tab" action does not prompt and correctly just opens a new tab.
  
  Neither KHTML nor the WebKit part put up this prompt, they just open a new tab as requested.
  
  The fix to NewWindowPage::acceptNavigationRequest() checks the type of navigation request (passed up from QWebEnginePage) and does not prompt for user requests for a new tab.
  
  The submitted diff is not reindented, so as not to confuse the code change with whitespace changes.  I will indent the block in accordance with coding style before committing.

TEST PLAN
  Built Konqueror (including the WebEnginePart plugin) with this change.  Observed that Ctrl-LMB, MMB or "Open in New Tab" simply open a new tab without prompting.  Observed that opening a site popup still prompts as before.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D24195

AFFECTED FILES
  webenginepart/src/webenginepage.cpp

To: marten, #plasma, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190924/056d7fc0/attachment.htm>