D19311: Add navigation history to forward/back buttons
David Hallas
noreply at phabricator.kde.org
Tue Sep 17 12:13:26 BST 2019
hallas added inline comments.
INLINE COMMENTS
> hallas wrote in dolphinmainwindow.cpp:95-103
> Thanks for the review feedback :)
>
> In the original patch I had a limit on the number of entries in the menu, but this was removed on request from review feedback, but would that be a way to solve it in combination with not adding duplicates? I just checked with my browser (Chrome) and that actually allows duplicates in the history, but I haven't tested how many entries it limits. @elvisangelaccio @ngraham what are your thoughts on this?
Actually, it seems like Chrome limits the navigation history to 12 entries, @ngraham would such a limit be an acceptable solution?
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D19311
To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190917/78893653/attachment.htm>
More information about the kfm-devel
mailing list