D23706: Fix wrong window titles

Elvis Angelaccio noreply at phabricator.kde.org
Sun Sep 15 10:57:46 BST 2019


elvisangelaccio added a comment.


  Nice, this seems to do the trick :)

INLINE COMMENTS

> dolphinviewcontainer.cpp:459
>      KFilePlacesModel *placesModel = DolphinPlacesModelSingleton::instance().placesModel();
> -    const auto& matchedPlaces = placesModel->match(placesModel->index(0,0), KFilePlacesModel::UrlRole, url(), 1, Qt::MatchExactly);
> +    const auto& matchedPlaces = placesModel->match(placesModel->index(0,0), KFilePlacesModel::UrlRole, QUrl(url().adjusted(QUrl::StripTrailingSlash).toString().append("/?")), 1, Qt::MatchRegExp);
>  

We should probably use `toString(QUrl::FullyEncoded)`, since this is how the URL is going to end up in the bookmark XML file used by the places model.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23706

To: nazark, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190915/556ba7d4/attachment.htm>


More information about the kfm-devel mailing list