D23757: Clean up hamburger menu and viewport and single-folder context menus

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1000
>  
> -    menu->addSeparator();
> +    // Add 'New Window' and 'New Tab' entries.
> +    addActionToMenu(ac->action(QStringLiteral("file_new")), menu);

...and also 'Recently Closed Tabs'

Or just "Add tabs-related entries"

Or just remove the comment :-)

> dolphinmainwindow.cpp:1024
>  
> -    added = addActionToMenu(ac->action(QStringLiteral("sort")), menu) |
> -            addActionToMenu(ac->action(QStringLiteral("view_mode")), menu) |

Why remove `sort`?

> dolphinmainwindow.cpp:1057
> -    goMenu->addAction(ac->action(QStringLiteral("closed_tabs")));
> -    KActionMenu *bookmarkMenu = new KActionMenu(i18nc("@title:menu", "&Bookmarks"), goMenu);
> -    m_bookmarkHandler->fillControlMenu(bookmarkMenu->menu(), ac);

Ah, I didn't think about Bookmarks. I guess it can go...

> ngraham wrote in dolphinmainwindow.cpp:1048-1053
> There's no logical grouping of "Help" and "Show Menubar", so I didn't think it made sense to put them in a section together.
> 
> Also, removing the separator generally alleviates the  "separator overload" effect that currently contributes to the the menu being too tall and visually overwhelming.

Fair enough :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23757

To: ngraham, #vdg, #dolphin, meven, elvisangelaccio, GB_2
Cc: GB_2, mmustac, elvisangelaccio, meven, ndavis, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190914/02770bd3/attachment.htm>