D23757: Clean up hamburger menu and viewport and single-folder context menus

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Could you please move the renaming of labels (e.g. "Hidden Files" to "Show Hidden Files") and the addition of icons to different commits? That would make this patch much easier to review.

INLINE COMMENTS

> dolphincontextmenu.cpp:227
>          } else if (m_baseUrl.scheme().contains(QLatin1String("search")) || m_baseUrl.scheme().contains(QLatin1String("timeline"))) {
> -            addOpenWithActions(fileItemActions);
> +//             addOpenWithActions(fileItemActions);
>  

Leftover?

> dolphinmainwindow.cpp:1036
> +    addActionToMenu(ac->action(QStringLiteral("show_filter_bar")), menu);
> +    addActionToMenu(ac->action(QStringLiteral("compare_files")), menu);
> +    addActionToMenu(ac->action(QStringLiteral("open_terminal")), menu);

I'm not sure about this one, since it will be disabled most of the time. If you want to compare 2 files you have to select both of them and then you will probably use the right-click.

I'd actually keep the "Tools" menu, while I agree with the removal of the "Go" menu (since you can use most of its actions from the toolbar).

> dolphinmainwindow.cpp:1048-1053
> +    addActionToMenu(ac->action(KStandardAction::name(KStandardAction::ShowMenubar)), menu);
>  
>      // Add "Help" menu
> -    menu->addMenu(m_helpMenu->menu());
> -
> -    menu->addSeparator();
> -    addActionToMenu(ac->action(KStandardAction::name(KStandardAction::ShowMenubar)), menu);
> +    auto helpMenu = m_helpMenu->menu();
> +    helpMenu->setIcon(QIcon::fromTheme(QStringLiteral("system-help")));
> +    menu->addMenu(helpMenu);

Hmm, I don't really see what we gain by shuffling "Help" and "Show Menubar" and removing the separator...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23757

To: ngraham, #vdg, #dolphin, meven, elvisangelaccio
Cc: GB_2, mmustac, elvisangelaccio, meven, ndavis, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190914/a4f5237f/attachment.htm>