D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham added a comment.


  More or less! A new things:
  
  1. Don't forget to add the function definition for `KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, int index)` to the header file
  2. Revert the change where you moved that section; it's now unnecessary
  3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this:
  
  
  
    if (plugin == "details"  /* this is pseudocode */) {
        q->insertPluginAt(plugin, 1);
    } else {
        q->insertPlugin(plugin);
    }
  
  I'm actually not sure how to check for what the plugin is though. Maybe someone from #frameworks <https://phabricator.kde.org/tag/frameworks/> can help.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190913/23e16b33/attachment.htm>