D23860: DolphinTabWidget: cleanup index-by-URL API usage

Elvis Angelaccio noreply at phabricator.kde.org
Wed Sep 11 00:15:47 BST 2019


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: feverfew.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Follow-up of D23655 <https://phabricator.kde.org/D23655> where we didn't have time to polish the code:
  
  - add a couple of variables to make the code more clear.
  - remove the `get` prefix which we usually don't use in Qt code.
  - make the function private since it's very tied to implementation.
  - add a new isUrlOpen public method as wrapper.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23860

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h

To: elvisangelaccio, feverfew
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190910/87daa342/attachment.htm>


More information about the kfm-devel mailing list