D23538: [dolphin] Animate gifs on preview

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> iasensio wrote in informationpanelcontent.cpp:249
> Sorry, but I don't get it. I mean the `else` in line 278 (270 before the patch). I hope to have rebased correctly.

Sorry my previous comment was not very clear.

Currently you have :

  if (isAnimatedImaget) {}
  if (isPhonon){}

I suggest to have

  if (isAnimatedImaget) {}
  else if (isPhonon){}

If you look at the code carefully you will see ` if (isPhonon){}` has no else block.
The following `else` (line 278 / 286)  is the else block of `if (InformationPanelSettings::previewsShown()) {`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190910/b4eca2dc/attachment.htm>