D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> meven wrote in informationpanel.cpp:322
> Yes indeed, only `file:/` and scheme less urls are locals, `thrash:/` or `recentlyused:/` are not.
> QUrl::fromLocalFile(fileName) with a fileName `trash:/` returns `file:/trash:/` which is not correct.
> 
> And this may needed to do this in other knotify slot* in the future.
> 
> I can add this in comment, if you file it is needed.

Looking at the git history, this was a KF5 porting bug. `KUrl(fileName)` was wrongly ported to `QUrl::fromLocalFile()`, while we should use `QUrl::fromUserInput()` instead.

While at it, we should fix all the occurrences in this file (e.g. `slotFilesRemoved()` and so on).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23668

To: meven, ngraham, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190909/85e60f55/attachment.htm>