D23475: [baloo-widgets] Apply condensed date to file metadata properties

[Méven Car]

meven requested changes to this revision.
meven added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> widgetfactory.cpp:81
>  //
> -static QString toString(const QVariant& value)
> +static QString formatDateTime(const QVariant& value, QLocale::FormatType dateFormat)
> +{

Could you make formatDateTime and toString private member function to avoid passing around dateFormat but instead use m_dateFormat directly ?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D23475

To: iasensio, #dolphin, elvisangelaccio, bruns, meven
Cc: meven, ngraham, bruns, #baloo, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, domson, ashaposhnikov, astippich, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190903/fba4cba2/attachment.htm>