D23655: Fixing bugs in new folders in tabs feature

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphintabwidget.cpp:394
>      for (int i = 0; i < count(); i++) {
> -        // Conversion to display string is necessary to deal with the '~' alias.
> -        // i.e. to acknowledge that ~/ is equivalent to /home/user/
> -        const QUrl tabUrl = tabPageAt(i)->activeViewContainer()->url();
> -        if (url == tabUrl ||
> -            url.toDisplayString(QUrl::StripTrailingSlash) == tabUrl.toDisplayString(QUrl::StripTrailingSlash)) {
> -            return i;
> +        QUrl primaryUrl = tabPageAt(i)->primaryViewContainer()->url();
> +        if (url == primaryUrl) {

`const`

> dolphintabwidget.cpp:397-398
> +            return qMakePair(i, true);
> +        } else if (auto secondView = tabPageAt(i)->secondaryViewContainer()) {
> +            // If split view is enabled in this tab, check the second view.
> +            if (url == secondView->url()) {

Please use `DolphinTabPage::splitViewEnabled()` (which makes the comment below redundant...)

Nitpick: `else` not necessary after `return`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23655

To: feverfew, elvisangelaccio
Cc: kfm-devel, ngraham, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190902/c7b1643b/attachment.htm>