D23672: Making sure that DBus objects are all created before the service

Alexander Saoutkin noreply at phabricator.kde.org
Mon Sep 2 12:00:57 BST 2019


feverfew created this revision.
feverfew added reviewers: elvisangelaccio, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  Currently the DBus service is created before the MainWindow DBus object is
  created. This can cause hangs if another service makes calls to a a method
  in an object that's not been initialised, when the service is already published.
  This patch defers the creation of the service until all DBus objects are
  created.

TEST PLAN
  Tested in KDevelop. Open several folders with Dolphin at once. Before this patch
  there would be noticeable hanging. With this patch all tabs instantly open with
  no hanging.

REPOSITORY
  R318 Dolphin

BRANCH
  DBusFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23672

AFFECTED FILES
  src/main.cpp

To: feverfew, elvisangelaccio, ngraham
Cc: kfm-devel, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190902/abeef31f/attachment.htm>


More information about the kfm-devel mailing list