D23232: [dolphin] Add an action to toggle the searchbar

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1099
>  
> +        // Disconnect toggle_search action from the old view container
> +        const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));

This comment doesn't add much, I'd remove it.

> dolphinmainwindow.cpp:1099-1101
> +        // Disconnect toggle_search action from the old view container
> +        const QAction* toggleSearchAction = actionCollection()->action(QStringLiteral("toggle_search"));
> +        toggleSearchAction->disconnect(oldViewContainer);

Please move this disconnect to the beginning of this if block. (to not get in between the two existing comments).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23232

To: iasensio, #dolphin, ngraham, #vdg, elvisangelaccio
Cc: ndavis, felixernst, elvisangelaccio, kfm-devel, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190901/1e9fc28a/attachment.htm>