D23538: [dolphin] Animate gifs on preview

Méven Car noreply at phabricator.kde.org
Sun Sep 1 18:59:44 BST 2019


meven added inline comments.

INLINE COMMENTS

> iasensio wrote in informationpanelcontent.cpp:249
> It is mutually exclusive with `usePhonon` but not with the `else` clause afterwards. I could move this block to there, if that makes it more clear.

No the next else after `if (usePhonon) {` if for `if (InformationPanelSettings::previewsShown()) {`.
The block `if (usePhonon) {` has no else block.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190901/a02405f9/attachment.htm>


More information about the kfm-devel mailing list