D24995: Fix terminal not always gaining focus when shown

Anthony Fieroni noreply at phabricator.kde.org
Mon Oct 28 07:41:14 GMT 2019


anthonyfieroni added subscribers: tcanabrava, anthonyfieroni.
anthonyfieroni added a reviewer: tcanabrava.
anthonyfieroni added a comment.


  @tcanabrava https://phabricator.kde.org/R319:6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7 `_viewSplitter->setFocusProxy(controller->view())` is missing so that's the problem to me, not related to Dolphin code.

INLINE COMMENTS

> terminalpanel.cpp:181
>          }
> -        m_terminalWidget->setFocus();
> +        m_terminalWidget->focusWidget()->setFocus();
>          connect(m_konsolePart, SIGNAL(currentDirectoryChanged(QString)),

It looks like konsole part widget changes its focus proxy?!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24995

To: alexmi, #dolphin, tcanabrava
Cc: anthonyfieroni, tcanabrava, broulik, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191028/8762a64e/attachment.htm>


More information about the kfm-devel mailing list