D19989: Unmounting busy device doesn't tell who is blocking

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> hallas wrote in placesitemmodel.cpp:481
> I have made this change, hope it is what you meant :)

Yes. Without a receiver, a lambda slot could lead to crashes. More details here: https://medium.com/genymobile/how-c-lambda-expressions-can-improve-your-qt-code-8cd524f4ed9f

REPOSITORY
  R318 Dolphin

BRANCH
  show_which_files_are_blocking_unmount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19989

To: hallas, #dolphin, elvisangelaccio, ngraham, broulik, meven
Cc: meven, davidedmundson, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191026/67fb8dd5/attachment.htm>