D24907: Fix error handling when renaming a single file

Méven Car noreply at phabricator.kde.org
Thu Oct 24 08:46:37 BST 2019


meven added inline comments.

INLINE COMMENTS

> dolphinview.cpp:1496
> +        // Nothing to do
> +    } else if (job->error() != KIO::ERR_USER_CANCELED) {
> +        emit errorMessage(job->errorString());

You can combine this ` if (job->error() != 0 && job->error() != KIO::ERR_USER_CANCELED) `
It is clearer IMO

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24907

To: alexmi, #vdg, #dolphin, elvisangelaccio
Cc: meven, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191024/d5914cc1/attachment.htm>


More information about the kfm-devel mailing list