D24422: [dolphin] Improve parsing of Baloo query searchString

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> chehrlic wrote in dolphinsearchbox.cpp:539
> Wouldn't it be better to use
> 
>   const QString searchString = query.searchString();
>   const auto subTerms = searchString.splitRef(QLatin1Char(' '), QString::SkipEmptyParts);
>   for (const QStringRef &subTerm : subTerms) {
>    ...
> 
> to avoid the creation of the substrings?

Nice, will do in this patch if @elvisangelaccio agrees, or else in a different one. Thanks for this kind of comments; I'm quite lost in all of the C++/Qt optimization subtleties.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24422

To: iasensio, #dolphin, elvisangelaccio, meven, bruns, ngraham
Cc: chehrlic, ngraham, bruns, kfm-devel, #baloo, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191022/c28136df/attachment.htm>