D19989: Unmounting busy device doesn't tell who is blocking

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemmodel.cpp:481
> +            KListOpenFilesJob* listOpenFilesJob = new KListOpenFilesJob(m_deviceToTearDown->filePath());
> +            connect(listOpenFilesJob, &KIO::Job::result, [this, listOpenFilesJob](KJob*) {
> +                KProcessList::KProcessInfoList blockingProcesses = listOpenFilesJob->processInfoList();

I meant

  connect(listOpenFilesJob, &KIO::Job::result, this, [...](...) { ... });

Without a receiver, the connection could lead to random crashes.

> placesitemmodel.cpp:482
> +            connect(listOpenFilesJob, &KIO::Job::result, [this, listOpenFilesJob](KJob*) {
> +                KProcessList::KProcessInfoList blockingProcesses = listOpenFilesJob->processInfoList();
> +                QString errorString;

Missing `const`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19989

To: hallas, #dolphin, elvisangelaccio, ngraham, broulik, meven
Cc: meven, davidedmundson, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191021/a7deffd0/attachment.htm>