D24422: [dolphin] Improve parsing of Baloo query searchString

Elvis Angelaccio noreply at phabricator.kde.org
Mon Oct 21 20:42:23 BST 2019


elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinsearchbox.cpp:548
> +            continue;
> +        } else if (subTerm == QStringLiteral("AND") && subTerm != subTerms.at(0) && subTerm != subTerms.back()) {
> +            continue;

Prefer `QLatin1String` for comparisons.

> dolphinsearchbox.cpp:550
> +            continue;
> +        } else if (subTerm == QStringLiteral("\"\"")) {
> +            continue;

Also here

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24422

To: iasensio, #dolphin, elvisangelaccio, meven, bruns, ngraham
Cc: ngraham, bruns, kfm-devel, #baloo, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191021/22462f83/attachment.htm>


More information about the kfm-devel mailing list