D24794: Disable keyboard accelerators for the tabs widget

Alex Miranda noreply at phabricator.kde.org
Sun Oct 20 10:55:53 BST 2019


alexmi created this revision.
alexmi added reviewers: VDG, Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
alexmi requested review of this revision.

REVISION SUMMARY
  Now that there are actions for switching to a specific tab with default
  Alt + <number> shortcuts, automatically assigned keyboard accelerators
  can result in ambiguous shortcuts when using specific tab names
  containing numbers.
  
  Not adding any accelerators for the tabs widget ensures the default
  shortcuts work reliably regardless of tab names.

TEST PLAN
  - Verify there are no ambiguous shortcuts when browsing folders with
  
  names containing only numbers
  
  - Verify other keyboard accelerators still work (menu bar, context menu
  
  and others)

REPOSITORY
  R318 Dolphin

BRANCH
  remove-tab-accelerators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24794

AFFECTED FILES
  src/dolphintabwidget.cpp

To: alexmi, #vdg, #dolphin
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191020/d942169e/attachment.htm>


More information about the kfm-devel mailing list